Skip to content

fix(lsp): correct workspace and document color capabilities and add tailwind lsp - #2736

Merged
bajrangCoder merged 3 commits into
mainfrom
feat/tailwindcss-lsp
Aug 17, 2026
Merged

fix(lsp): correct workspace and document color capabilities and add tailwind lsp#2736
bajrangCoder merged 3 commits into
mainfrom
feat/tailwindcss-lsp

Conversation

@bajrangCoder

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added the enhancement New feature or request label Aug 14, 2026
@bajrangCoder bajrangCoder changed the title fix(lsp): correct workspace and document color capabilities fix(lsp): correct workspace and document color capabilities and add tailwind lsp Aug 14, 2026
@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds an opt-in Tailwind CSS language server and corrects LSP workspace-root, workspace-folder, language-alias, and document-color capability handling.

  • Registers the Tailwind server and its npm installer in the built-in catalog.
  • Normalizes JavaScript and TypeScript language aliases for Tailwind servers.
  • Advertises the runtime root during initialization while preventing duplicate initial workspace-folder notifications.
  • Declares document-color dynamic registration unsupported and adds focused unit coverage.

Confidence Score: 4/5

The PR is not yet safe to merge because enabled Tailwind clients still discard watched-file registrations and can present stale completions and diagnostics after project changes.

The transport acknowledges client/registerCapability without storing or applying registrations, and no watched-file notification path was added, so the previously reported Tailwind stale-state failure remains.

Files Needing Attention: src/cm/lsp/transport.ts, src/cm/lsp/clientManager.ts

Important Files Changed

Filename Overview
src/cm/lsp/clientManager.ts Passes the runtime workspace root into initialization and seeds the initial folder to avoid duplicate folder-change notifications.
src/cm/lsp/workspace.ts Initializes workspace-folder tracking from folders already advertised during LSP initialization.
src/cm/lsp/serverRegistry.ts Detects Tailwind definitions and normalizes their JavaScript and TypeScript language aliases.
src/cm/lsp/servers/tailwind.ts Defines the disabled-by-default Tailwind server, launcher, installer, supported languages, and feature configuration.
src/cm/lsp/documentColors.ts Correctly declares that document-color dynamic registration is unsupported.

Sequence Diagram

sequenceDiagram
  participant Editor
  participant Manager as LspClientManager
  participant Workspace as AcodeWorkspace
  participant Tailwind as Tailwind LSP
  Editor->>Manager: Open supported document
  Manager->>Tailwind: initialize(rootUri, workspaceFolders)
  Manager->>Workspace: seed initialFolders
  Workspace-->>Manager: suppress duplicate initial-folder add
  Manager->>Tailwind: attach document with normalized language ID
Loading

Reviews (2): Last reviewed commit: "fix" | Re-trigger Greptile

Comment thread src/cm/lsp/clientManager.ts Outdated
@bajrangCoder

This comment was marked as outdated.

@bajrangCoder
bajrangCoder added this pull request to the merge queue Aug 17, 2026
Merged via the queue into main with commit 2d3ba93 Aug 17, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Aug 17, 2026
@bajrangCoder
bajrangCoder deleted the feat/tailwindcss-lsp branch August 17, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant